#141680: "incorrect score display"
Kāds ir šis ziņojums?
Kas notika? Lūdzu izvēlies no zemākredzamajiem
Kas notika? Lūdzu izvēlies no zemākredzamajiem
Lūdzu, pārbaudiet, vai par šo pašu tēmu jau ir ziņojums
Ja jā, lūdzu, balsojiet par šo ziņojumu. Ziņojumiem ar vislielākajām balsīm tiek dota PRIORITĀTE!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Detalizēts apraksts
-
• Lūdzu nokopē/ielīmē kļūdas ziņu, ko redzi ekrānā, ja tāda ir.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Lūdzu paskaidro, ko Tu vēlējies darīt, ko Tu izdarīji un kas notika
• Kāda ir Tava pārlūkprogramma?
opera
-
• Lūdzu iekopē tekstu, kas redzams angļu, nevis tavā valodā. Ja Tev ir ekrānuzņēmums, kurā redzama kļūme (laba prakse), vari izmantot Imgur.com , lai to augšupielādētu un kopētu/ielīmētu saiti šeit.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Vai šis teksts ir pieejams tulkošanas sistēmā? Ja jā, vai tas ir ticis tulkots pēdējo 24 stundu laikā?
• Kāda ir Tava pārlūkprogramma?
opera
-
• Lūdzu, paskaidrojiet savu ieteikumu precīzi un kodolīgi, lai tas būtu pēc iespējas vieglāk saprotams.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kāda ir Tava pārlūkprogramma?
opera
-
• Kas tika attēlots ekrānā, kad Tu tiki bloķēts (tukšs ekrāns? Daļa no spēles interfeisa? Ziņa par kļūdu?)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kāda ir Tava pārlūkprogramma?
opera
-
• Kura noteikumu daļa netika ņemta vērā BGA versijā?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Vai noteikumu pārkāpums ir redzams spēles atkārtojumā? Ja jā, tad kurā gājienā?
• Kāda ir Tava pārlūkprogramma?
opera
-
• Kādu spēles darbību Tu vēlējies veikt?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Ko tu dari, lai panāktu šo spēles darbību?
-
• Kas notika, kad veicāt šo darbību (kļūdas paziņojums, spēles informācijas paziņojums,...)?
• Kāda ir Tava pārlūkprogramma?
opera
-
• Kurā spēles solī problēma parādījās (kas bija tā brīža spēles instrukcija)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Kas notika, kad mēģinājāt veikt spēles darbību (kļūdas paziņojums, spēles informācijas paziņojums,...)?
• Kāda ir Tava pārlūkprogramma?
opera
-
• Lūdzu aprakstiet radušos problēmu. Ja Tev ir ekrānuzņēmums, kurā redzama kļūme (laba prakse), vari izmantot Imgur.com , lai to augšupielādētu un kopētu/ielīmētu saiti šeit.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kāda ir Tava pārlūkprogramma?
opera
-
• Lūdzu iekopē tekstu, kas redzams angļu, nevis tavā valodā. Ja Tev ir ekrānuzņēmums, kurā redzama kļūme (laba prakse), vari izmantot Imgur.com , lai to augšupielādētu un kopētu/ielīmētu saiti šeit.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Vai šis teksts ir pieejams tulkošanas sistēmā? Ja jā, vai tas ir ticis tulkots pēdējo 24 stundu laikā?
• Kāda ir Tava pārlūkprogramma?
opera
-
• Lūdzu, paskaidrojiet savu ieteikumu precīzi un kodolīgi, lai tas būtu pēc iespējas vieglāk saprotams.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Kāda ir Tava pārlūkprogramma?
opera
Ziņojuma vēsture
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Pievieno kaut ko šim ziņojumam
- Cita galda ID / gājiena ID
- Vai F5 atrisināja šo problēmu?
- Vai šī problēma parādās vairākas reizes? Katru reizi? Nekonkrētās reizēs?
- Ja Tev ir ekrānuzņēmums, kurā redzama kļūme (laba prakse), vari izmantot Imgur.com , lai to augšupielādētu un kopētu/ielīmētu saiti šeit.
